fix(auth): Defines missing DecodedIdToken types.#852
Conversation
hiranya911
changed the title
DecodedIdToken types.DecodedIdToken types.
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
LGTM
Over to @egilmorez for doc review.
egilmorez
left a comment
egilmorez
left a comment
There was a problem hiding this comment.
Some suggestions and questions, thanks!
src/auth.d.ts
Outdated
| auth_time: number; | ||
|
|
||
| /** | ||
| * The email corresponding to the user who the ID token belonged to, if available. |
There was a problem hiding this comment.
The email of the user to whom the ID token belonged, if available.
src/auth.d.ts
Outdated
| email?: string; | ||
|
|
||
| /** | ||
| * Whether the email corresponding to the user who the ID token belonged to is |
There was a problem hiding this comment.
Suggest "Whether or not the email of the user to whom the ID token belonged is verified, provided the user has an email."
Are the valid values true and false?
There was a problem hiding this comment.
Yes, true or false. Done.
src/auth.d.ts
Outdated
| iss: string; | ||
|
|
||
| /** | ||
| * The phone number corresponding to the user who the ID token belonged to, |
There was a problem hiding this comment.
Suggest "The phone number of the user to whom the ID token belonged, if available."
Or -- can these be present tense "belongs?" That would be preferable if it is accurate.
There was a problem hiding this comment.
Done on both.
src/auth.d.ts
Outdated
| phone_number?: string; | ||
|
|
||
| /** | ||
| * The photo URL corresponding to the user who the ID token belonged to, |
There was a problem hiding this comment.
Suggest "The photo URL for the user to whom the ID token belonged..."
3 participants
Fixes #846
RELEASE NOTE: Exposed
email,email_verified,phone_numberandpicturefields from theDecodedIdTokentype.